Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround for compile error in clang 13 on macOS #1485

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Workaround for compile error in clang 13 on macOS #1485

merged 1 commit into from
Jan 29, 2025

Conversation

jrouwe
Copy link
Owner

@jrouwe jrouwe commented Jan 29, 2025

Fixes #1482

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

uilianries added a commit to uilianries/JoltPhysics that referenced this pull request Jan 29, 2025
@uilianries
Apply patch from PR jrouwe#1485
12297d7 
Signed-off-by: Uilian Ries <[email protected]>
uilianries
uilianries approved these changes Jan 29, 2025
View reviewed changes
Copy link

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Working as reported at #1482 (comment)

@jrouwe jrouwe merged commit 294c228 into master Jan 29, 2025
73 checks passed
@jrouwe jrouwe deleted the bugfix/clang13 branch January 29, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Could not build JoltPhysics 5.2.0 with Apple Clang 13: incomplete type 'JPH::Color'
2 participants
@jrouwe @uilianries