Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uuid as user pk #52

Merged
merged 4 commits into from
Oct 5, 2020
Merged

uuid as user pk #52

merged 4 commits into from
Oct 5, 2020

Conversation

jrobichaud
Copy link
Owner

@jrobichaud jrobichaud commented Oct 5, 2020

closes #51

fadedDexofan and others added 3 commits August 27, 2020 00:04
Fix for py-ampq FrameSyntaxError during serialization in Celery
Convert user_id to str if UUID used as PK
@jrobichaud jrobichaud self-assigned this Oct 5, 2020
@jrobichaud jrobichaud changed the title Add failing test for uuid as user id Add failing test for uuid as user pk Oct 5, 2020
@codecov
Copy link

codecov bot commented Oct 5, 2020

Codecov Report

Merging #52 into master will increase coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #52      +/-   ##
===========================================
+ Coverage   99.53%   100.00%   +0.46%     
===========================================
  Files          40        40              
  Lines        1080      1106      +26     
===========================================
+ Hits         1075      1106      +31     
+ Misses          5         0       -5     
Impacted Files Coverage Δ
django_structlog/middlewares/request.py 100.00% <100.00%> (ø)
test_app/tests/middlewares/test_request.py 100.00% <100.00%> (ø)
test_app/tests/celery/test_steps.py 100.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7961dcd...ee7ddb5. Read the comment docs.

@jrobichaud jrobichaud changed the title Add failing test for uuid as user pk uuid as user pk Oct 5, 2020
@jrobichaud jrobichaud merged commit 1c7337c into master Oct 5, 2020
@jrobichaud jrobichaud deleted the uuid-as-user-pk branch October 5, 2020 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent user_id from django to celery when using UUID as pk for User model
2 participants