Add log_kwargs to bind_extra_task_metadata #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 502 502
Branches 28 28
=========================================
Hits 502 502 ☔ View full report in Codecov by Sentry. |
shtoltz
reviewed
Mar 14, 2024
| ) | ||
| logger.info("request_started", **log_kwargs) |
There was a problem hiding this comment.
Could you add please the same logic to request_finished and request_failed events? So it would be possible to remove/modify their context (code and request) as well.
shtoltz
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #484