Changes to use python-ipware #358
Conversation
As django-ipware is being deprecated in favor of python-ipware, and the fact they share the same import namespace any project python-ipware Signed-off-by: Russell Osborne <[email protected]>
| from ipware import IpWare | ||
|
|
||
| # Instantiate IpWare with default values | ||
| ipw = IpWare() |
There was a problem hiding this comment.
should this moved on the top of the file?
There was a problem hiding this comment.
I think it has to be added to app_settings.py and be configurable through settings.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #358 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 32 32
Lines 459 459
Branches 23 23
=========================================
Hits 459 459 ☔ View full report in Codecov by Sentry. |
|
Hi @rposborne. I was wondering in which direction it was going finally:
? |
|
Closing as they are going to maintain the old one. |
|
As you seem to be a I was wondering if it would be useful to expose Some parameters have to be passed in the constructor and currently they are unavailable since django-structlog instantiates it directly. I am referring mainly about the proxy configuration. What do you think? |
As django-ipware is being deprecated in favor of python-ipware, and the fact they share the same import namespace any project python-ipware
This is on hold until a conclusion is reached for un33k/python-ipware#10