-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic/adapt to gitlab ci #19
Conversation
gergondet
commented
Nov 19, 2015
- Provide a gitlab-ci.yml example file
- Implement an option to disable sudo even on travis builds (CI_REQUIRE_SUDO not tested on travis)
- Do not rely on the scripts being in .travis
* Provide a gitlab-ci.yml example file * Implement an option to disable sudo even on travis builds (not tested)
👍 With GitLab CI, apt packages are supposed to be installed in those scripts as well? Now that Travis offers a docker-based build, apt packages can be provided in |
For now, apt-dependencies are given in .gitlab-ci.yml in the same way (i.e. by defining the environment variable APT_DEPENDENCIES) and with the same effect, i.e. trigger apt-get install calls in before_script. However, since (in our use-case) the gitlab-ci builder is root in its docker container, we do not require the use of sudo. I am unsure about the situation with travis and container-based builds but it may be worth a try although this does not seem to be the proper way to add apt-dependencies in that case. |
For travis, we can use this rather than the current However, sources need to be approved (see their whitelist). This may be a problem for ROS (cf. travis-ci/apt-source-safelist#171). For |
set -o errtrace | ||
trap on_error ERR | ||
;; | ||
esac |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason for moving this out of verbose_errors.sh
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No particular reason (except for a bug earlier in the patch cycle). I've restored this part to the previous version.