Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/adapt to gitlab ci #19

Closed
wants to merge 3 commits into from

Conversation

gergondet
Copy link
Member

  • Provide a gitlab-ci.yml example file
  • Implement an option to disable sudo even on travis builds (CI_REQUIRE_SUDO not tested on travis)
  • Do not rely on the scripts being in .travis

gergondet and others added 2 commits November 13, 2015 19:13
* Provide a gitlab-ci.yml example file
* Implement an option to disable sudo even on travis builds (not tested)
@bchretien
Copy link
Member

👍

With GitLab CI, apt packages are supposed to be installed in those scripts as well? Now that Travis offers a docker-based build, apt packages can be provided in .travis.yml, removing the need for sudo in most parts of the script.

@gergondet
Copy link
Member Author

For now, apt-dependencies are given in .gitlab-ci.yml in the same way (i.e. by defining the environment variable APT_DEPENDENCIES) and with the same effect, i.e. trigger apt-get install calls in before_script.

However, since (in our use-case) the gitlab-ci builder is root in its docker container, we do not require the use of sudo. I am unsure about the situation with travis and container-based builds but it may be worth a try although this does not seem to be the proper way to add apt-dependencies in that case.

@bchretien
Copy link
Member

For travis, we can use this rather than the current APT_DEPENDENCIES + sudo: http://docs.travis-ci.com/user/apt/

However, sources need to be approved (see their whitelist). This may be a problem for ROS (cf. travis-ci/apt-source-safelist#171).

For sudo requirements, if that only concerns APT packages + ccache, we can probably avoid it. We'd need to clean the scripts though, and have different CI-agnostic functions e.g. install_dependencies(), process_coverage(), process_doc().

set -o errtrace
trap on_error ERR
;;
esac
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for moving this out of verbose_errors.sh?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason (except for a bug earlier in the patch cycle). I've restored this part to the previous version.

@gergondet gergondet closed this Dec 1, 2015
@gergondet gergondet mentioned this pull request Dec 1, 2015
@gergondet gergondet deleted the topic/AdaptToGitlabCI branch May 24, 2019 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants