De-Duplicating Global Regex Replacements for Rebasing #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome, thanks. Would you mind adding a test case to prevent regressions? |
|
Oooooh, asking a lot... ;) I'll see what I can do. |
|
Okay, so I spent over an hour trying to make this test case, and didn't manage to reproduce the exact scenario. I'm not interested in diving into the Juice codebase and understanding what it's doing, and I can't spend any more time on this. Perhaps you'll have better luck setting up a test case, but in either case this PR does fix the problem. |
|
Thanks for the effort, I'll go ahead and merge but probably won't publish a release until I get a test added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2
Sorry, took me a while :)