Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unescape HTML entities in the URLs extracted from attributes #11

Merged
merged 2 commits into from
Sep 30, 2015
Merged

Unescape HTML entities in the URLs extracted from attributes #11

merged 2 commits into from
Sep 30, 2015

Conversation

thorn0
Copy link
Contributor

@thorn0 thorn0 commented Sep 29, 2015

Also optimize and improve regexps.

@jrit
Copy link
Owner

jrit commented Sep 30, 2015

It seems like the tests should likely cover the spaces to the sides of = because that isn't particularly common and I could see someone removing that as unnecessary later if that wouldn't prompt a test failure. The rest of it looks good. Thanks.

@thorn0
Copy link
Contributor Author

thorn0 commented Sep 30, 2015

Good point. Done.

@jrit
Copy link
Owner

jrit commented Sep 30, 2015

Looks good.

jrit added a commit that referenced this pull request Sep 30, 2015
Unescape HTML entities in the URLs extracted from attributes
@jrit jrit merged commit 4a95388 into jrit:master Sep 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants