skip links starting with # for scripts and anchors

jrit · Mar 19, 2019 · 045c32d · 045c32d
1 parent db9c79f
commit 045c32d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -5,7 +5,7 @@
   },
   "name": "web-resource-inliner",
   "description": "Inlines img, script and link tags into the same file.",
-  "version": "4.3.0",
+  "version": "4.3.1",
   "keywords": [
     "inline",
     "js",

diff --git a/src/html.js b/src/html.js
@@ -190,7 +190,7 @@ module.exports = function( options, callback )
             ( settings.scripts || inlineAttributeRegex.test( found[ 0 ] ) ) )
         {
             var src = unescape( found[ 2 ] ).trim();
-            if ( src )
+            if ( src && src.indexOf( "#" ) !== 0 )
             {
                 tasks.push( replaceScript.bind(
                 {
@@ -231,7 +231,7 @@ module.exports = function( options, callback )
             ( settings.images || inlineAttributeRegex.test( found[ 0 ] ) ) )
         {
             var src = unescape( found[ 2 ] ).trim();
-            if ( src ) {
+            if ( src && src.indexOf( "#" ) !== 0 ) {
                 tasks.push( replaceImg.bind(
                 {
                     element: found[ 0 ],

diff --git a/test/spec.js b/test/spec.js
@@ -525,7 +525,9 @@ describe( "html", function()
 
         it( "should not try to inline a link that starts with #", function( done )
         {
-            const content = '<link href="#" rel="stylesheet" /><link href="#aaa" rel="stylesheet" />';
+            const content = '<link href="#" rel="stylesheet" /><link href="#aaa" rel="stylesheet" />'
+              + '<img src="#" /><img src="#aaa" />'
+              + '<a href="#" /><a href="#aaa" />';
 
             inline.html( {
                     fileContent: content,