Fixes bug related to interaction with emacs's native compilation #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change specifically fixes this bug for me: ardumont/markdown-toc#51 IIUC, `#` is used to inform the byte-compiler that the expression can be byte-compiled. But in this case there is nothing to compile since it's a symbol.
|
This doesn't seem to be the right fix. The bug has returned back. If I restart emacs, it doesn't happen again. This needs more fiddling. |
|
I suppose this is same as #578. Workaround is #578 (comment) |
|
@syohex Thanks, I didn't know about that. Is there a more proper fix for it instead of opting out of native compilation for markdown mode ? |
I have no idea yet. |
|
Cool, thanks for the update. The workaround would keep me sane. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change specifically fixes this bug for me:
ardumont/markdown-toc#51
IIUC,
#is used to inform the byte-compiler that the expression canbe byte-compiled. But in this case there is nothing to compile since
it's a symbol.
Related Issue
ardumont/markdown-toc#51
Type of Change
Checklist
make test).