-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid undefined LFS_TYPE_REG/DIR. #88
Conversation
It seems all versions of mypy between 1.0.1 and 1.9.0 crash due to this definition ( python/mypy#17059 ).
I think this looks good to me; the pyi file is hand-crafted, but this assignment seems like an oversight. Thanks! |
so I'm holding off on this for a tiny bit, I think it may be more appropriate to change all of the value assignments in the I'm running the following mypy on an M1 mac, and I'm unable to reproduce the crash mentioned in python/mypy#17059. I'll try some other things to see if I can reproduce.:
|
ok I'm able to reproduce, my environment was previously a lil messed up:
I'm going to try and replace stuff with |
Ok so, I've updated this PR so that I will not be changing the other default values in the stub, because some IDEs show that information, so may as well keep it (see python/typeshed#8988). |
this has been released as part of v0.10.1 EDIT: hopefully will be released later today; there's some third-party CI stuff that is down at the moment preventing a release. EDIT2: released. |
Thanks for the quick action, the new release works for me! |
It seems all versions of mypy between 1.0.1 and 1.9.0 crash due to this definition ( python/mypy#17059 ).
This seems to be a workaround. However, I'm not sure if the
lfs.pyi
is auto-generated or hand-written. There may be a better solution to this.