Skip to content

Commit

Permalink
Remove unneeded join
Browse files Browse the repository at this point in the history
Seen in ManageIQ#14852

It's already a single string, there's no need to wrap it in an array and
join the single element with a space.
  • Loading branch information
jrafanie committed Apr 24, 2017
1 parent d199f44 commit fb58e53
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions spec/lib/rbac/filterer_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -909,8 +909,8 @@ def get_rbac_results_for_and_expect_objects(klass, expected_objects)
group.entitlement.set_belongsto_filters([])
group.save!

ansible_configuration_script_with_tag.tag_with(['/managed/environment/prod'].join(' '), :ns => '*')
ansible_playbook_with_tag.tag_with(['/managed/environment/prod'].join(' '), :ns => '*')
ansible_configuration_script_with_tag.tag_with('/managed/environment/prod', :ns => '*')
ansible_playbook_with_tag.tag_with('/managed/environment/prod', :ns => '*')
end

it 'lists only tagged ConfigurationScripts' do
Expand Down Expand Up @@ -962,7 +962,7 @@ def get_rbac_results_for_and_expect_objects(klass, expected_objects)
group.entitlement.set_belongsto_filters([])
group.save!

network_object_with_tag.tag_with(['/managed/environment/prod'].join(' '), :ns => '*')
network_object_with_tag.tag_with('/managed/environment/prod', :ns => '*')
end

it "lists only tagged #{network_model}" do
Expand Down

0 comments on commit fb58e53

Please sign in to comment.