Skip to content

Commit

Permalink
Normalize on Camelcase Html for consistency with loading
Browse files Browse the repository at this point in the history
We need to match MiqReport::Formatters:Html and MiqReport::Generator::Html or
change them to also be HTML.  I decided on Html because HTML would also require
us to teach zeitwerk another acronym.
  • Loading branch information
jrafanie committed May 2, 2023
1 parent 14a845f commit 9e0de20
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion lib/manageiq/reporting/formatter.rb
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ module ReportFormatter
deprecate_constant 'C3Charting', 'ManageIQ::Reporting::Formatter::C3Charting'
deprecate_constant 'ChartCommon', 'ManageIQ::Reporting::Formatter::ChartCommon'
deprecate_constant 'Converter', 'ManageIQ::Reporting::Formatter::Converter'
deprecate_constant 'ReportHTML', 'ManageIQ::Reporting::Formatter::HTML'
deprecate_constant 'ReportHTML', 'ManageIQ::Reporting::Formatter::Html'
deprecate_constant 'ReportRenderer', 'ManageIQ::Reporting::Formatter::ReportRenderer'
deprecate_constant 'ReportText', 'ManageIQ::Reporting::Formatter::Text'
deprecate_constant 'ReportTimeline', 'ManageIQ::Reporting::Formatter::Timeline'
Expand Down
2 changes: 1 addition & 1 deletion lib/manageiq/reporting/formatter/html.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
module ManageIQ
module Reporting
module Formatter
class HTML < Ruport::Formatter
class Html < Ruport::Formatter
renders :html, :for => ManageIQ::Reporting::Formatter::ReportRenderer

def build_html_title
Expand Down

0 comments on commit 9e0de20

Please sign in to comment.