Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* 1.7.0 introduced merge_nil_values, ironically by me, which we have to disable. This is because we often have leaf configurations with nil values as examples, which overwrite core values, leading to lots of problems. For now we have to disable this behavior. https://github.com/railsconfig/config/pull/196/files See also: https://github.com/ManageIQ/manageiq/pull/16982/files * 2.0.0 changed the Config constant to be defined on Object, not Kernel, so we need to update our configuration to reflect this same change: https://github.com/railsconfig/config/pull/227/files Also, config gem at 1.6.1 was loading dry-validation which was really slow. Now with 2.0.0, it uses dry-schema, which is slightly less slow. It seems to save ~0.3 seconds on rails boot. Config 1.6.1: ``` 04:49:04 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 6.12s user 3.84s system 88% cpu 11.227 total 04:49:17 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.81s user 3.23s system 99% cpu 9.133 total 04:49:28 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.92s user 3.32s system 98% cpu 9.338 total 04:49:38 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 6.09s user 3.55s system 98% cpu 9.793 total ``` Config 2.0.0: ``` 04:43:03 ~/Code/manageiq (master) (2.6.5) - time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.90s user 3.53s system 90% cpu 10.403 total 04:43:16 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.54s user 2.99s system 99% cpu 8.610 total 04:43:25 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.64s user 3.14s system 98% cpu 8.879 total 04:43:35 ~/Code/manageiq (master) (2.6.5) + time ruby -e "require './config/environment'" ruby -e "require './config/environment'" 5.64s user 3.12s system 99% cpu 8.841 total ```
- Loading branch information