Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker: Capitalize some Indonesian words #2067

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Datepicker: Capitalize some Indonesian words #2067

merged 2 commits into from
Jul 14, 2022

Conversation

ddevsr
Copy link
Contributor

@ddevsr ddevsr commented Apr 6, 2022

Fixing typo bahasa in translation ID for Datepicker

@ddevsr
Fix typo
282dfed 
Fix typo bahasa
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 6, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ddevsr / name: Denny Septian Panggabean (282dfed)

@ddevsr ddevsr changed the title Fix typo Fix typo translation ID in Datepicker Apr 6, 2022
@fnagel
Copy link
Member

fnagel commented Jul 7, 2022

Thanks for your contribution!

We need some more reviews of the localization before merging this. Please see here for more info: https://jqueryui.pbworks.com/w/page/139157592/Adding%20translations

@fnagel fnagel self-assigned this Jul 7, 2022
@fnagel
Copy link
Member

fnagel commented Jul 7, 2022 •
edited
Loading

@ddevsr Do I understand this right? You just removed the symbols before next and prev and did an first char to uppercase for some localization strings.

@fnagel fnagel closed this Jul 7, 2022
@fnagel fnagel reopened this Jul 7, 2022
@fnagel
Copy link
Member

fnagel commented Jul 7, 2022

Close and reopen for re-running the tests.

@fnagel fnagel mentioned this pull request Jul 8, 2022
Closed
fnagel pushed a commit to fnagel/jquery-ui that referenced this pull request Jul 9, 2022
@adalid-1 @fnagel
Datepicker: Remove symbols in localization
dfff5e7 
Fixes jquerygh-2048
Closes jquerygh-2050
Ref jquerygh-2067
mgol pushed a commit to fnagel/jquery-ui that referenced this pull request Jul 14, 2022
@adalid-1 @mgol
Datepicker: Remove symbols in localization
6bcf28b 
Fixes jquerygh-2048
Closes jquerygh-2050
Ref jquerygh-2067
mgol pushed a commit that referenced this pull request Jul 14, 2022
@adalid-1 @mgol
Datepicker: Remove symbols in localization
3126e12 
Fixes gh-2048
Closes gh-2050
Ref gh-2067
mgol
mgol approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@mgol mgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mgol mgol added this to the 1.13.2 milestone Jul 14, 2022
@mgol mgol changed the title Fix typo translation ID in Datepicker Datepicker: Capitalize some Indonesian words Jul 14, 2022
@mgol mgol merged commit 9d1fc97 into jquery:main Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgol mgol mgol approved these changes

Assignees

@fnagel fnagel

Labels
Bug Localization
Milestone
1.13.2
Development

Successfully merging this pull request may close these issues.
3 participants
@ddevsr @fnagel @mgol