Skip to content

Commit

Permalink
Build: Downgrade uglify-js to fix tests in IE 9
Browse files Browse the repository at this point in the history
We can upgrade for Migrate 4.0. It's not worth spending time on figuring
out how to fix IE 9 with new UglifyJS at this point.

The `ie` option had to be renamed to `ie8` as the older version doesn't
support the former. In Migrate 4 we can remove it altogether.

Closes gh-479
  • Loading branch information
mgol authored Jan 15, 2023
1 parent 34db0ea commit bce6d06
Show file tree
Hide file tree
Showing 3 changed files with 49 additions and 31 deletions.
4 changes: 2 additions & 2 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ module.exports = function( grunt ) {

// Support: Android 4.0 only
// UglifyJS 3 breaks Android 4.0 if this option is not enabled.
// This is in lieu of setting ie for all of mangle, compress, and output
ie: true
// This is in lieu of setting ie8 for all of mangle, compress, and output
ie8: true
},
banner: "/*! jQuery Migrate v<%= pkg.version %>" +
" | (c) <%= pkg.author.name %> | jquery.org/license */",
Expand Down
74 changes: 46 additions & 28 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"grunt": "1.5.3",
"grunt-cli": "1.4.3",
"grunt-compare-size": "0.4.2",
"grunt-contrib-uglify": "5.0.1",
"grunt-contrib-uglify": "4.0.1",
"grunt-contrib-watch": "1.1.0",
"grunt-eslint": "24.0.0",
"grunt-karma": "4.0.2",
Expand Down

0 comments on commit bce6d06

Please sign in to comment.