Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync #94

Merged
merged 8 commits into from
Oct 12, 2017
Merged

Sync #94

merged 8 commits into from
Oct 12, 2017

Conversation

jquense
Copy link
Owner

@jquense jquense commented May 23, 2017

No description provided.

@jquense jquense mentioned this pull request Jun 27, 2017
@ctavan
Copy link
Contributor

ctavan commented Aug 17, 2017

@jquense what are your plans with this?

I'd be really interested in having an option to perform sync validation as well as async validation: My usecase would be to be able to do async validations on the server but running the sync subset of these validations on the browser as well in conjunction with redux-form which only supports sync field-level validations.

Is there anything I could help you with to get this merged?

@jquense
Copy link
Owner Author

jquense commented Aug 17, 2017

@ctavan yes there is! I'm happy to get this merged but it adds a lot of complexity and i'd let to get some feedback from folks using it. I don't have a lot of use cases right now for sync validations so it's a bit hard to test. IF you want to give it a shot in a project or hit it hard with examples and see if it falls over that would really help a lot towards feeling confident that this isn't going to be a mistake to merge :P

@ctavan
Copy link
Contributor

ctavan commented Aug 17, 2017

Cool. I'll rebase the branch and test it in my projects.

@retorquere
Copy link

I would be very interested in this. I'm looking for a validation library I can use in conjunction with lokijs and async validation would be very complicated if possible at all.

@retorquere
Copy link

I'm currently using ajv which is great except for validation of native dates.

@ctavan
Copy link
Contributor

ctavan commented Sep 6, 2017

I will continue working on this as soon as #115 has been merged.

@ctavan ctavan mentioned this pull request Sep 7, 2017
@jquense jquense mentioned this pull request Sep 25, 2017
@jquense jquense merged commit e30e09e into master Oct 12, 2017
Tadwork pushed a commit to Tadwork/yup that referenced this pull request Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants