Improves error messages for prefab values

jqno · Aug 2, 2023 · fea9162 · fea9162
1 parent 334bdc2
commit fea9162
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/equalsverifier-core/src/main/java/nl/jqno/equalsverifier/internal/util/Validations.java b/equalsverifier-core/src/main/java/nl/jqno/equalsverifier/internal/util/Validations.java
@@ -80,10 +80,13 @@ private static <T> void validateExampleIsUnequal(T example, List<T> equalExample
     }
 
     public static <T> void validateRedAndBluePrefabValues(Class<T> type, T red, T blue) {
-        validateNotNull(type, "type is null.");
-        validateNotNull(red, "red value is null.");
-        validateNotNull(blue, "blue value is null.");
-        validate(red.equals(blue), "both values are equal.");
+        validateNotNull(type, "prefab value type is null.");
+        validateNotNull(red, "red prefab value of type " + type.getSimpleName() + " is null.");
+        validateNotNull(blue, "blue prefab value of type " + type.getSimpleName() + " is null.");
+        validate(
+            red.equals(blue),
+            "both prefab values of type " + type.getSimpleName() + " are equal."
+        );
     }
 
     public static <T> void validateGenericPrefabValues(

diff --git a/...re/src/test/java/nl/jqno/equalsverifier/integration/operational/WithPrefabValuesTest.java b/...re/src/test/java/nl/jqno/equalsverifier/integration/operational/WithPrefabValuesTest.java
@@ -61,7 +61,10 @@ public void throw_whenThePrefabValuesAreTheSame() {
                     .withPrefabValues(FinalPoint.class, red, red)
             )
             .assertThrows(IllegalStateException.class)
-            .assertMessageContains("Precondition", "both values are equal");
+            .assertMessageContains(
+                "Precondition",
+                "both prefab values of type FinalPoint are equal"
+            );
     }
 
     @Test
@@ -76,7 +79,10 @@ public void throw_whenThePrefabValuesAreEqual() {
                     .withPrefabValues(FinalPoint.class, red1, red2)
             )
             .assertThrows(IllegalStateException.class)
-            .assertMessageContains("Precondition", "both values are equal");
+            .assertMessageContains(
+                "Precondition",
+                "both prefab values of type FinalPoint are equal"
+            );
     }
 
     @Test