#286 Adds prefab value for PropetyChangeSupport

jqno · Mar 12, 2020 · 83df3ee · 83df3ee
1 parent cddcc69
commit 83df3ee
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/main/java/nl/jqno/equalsverifier/internal/prefabvalues/JavaApiPrefabValues.java b/src/main/java/nl/jqno/equalsverifier/internal/prefabvalues/JavaApiPrefabValues.java
@@ -5,6 +5,7 @@
 import static nl.jqno.equalsverifier.internal.reflection.Util.objects;
 
 import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
+import java.beans.PropertyChangeSupport;
 import java.io.File;
 import java.lang.reflect.*;
 import java.math.BigDecimal;
@@ -498,6 +499,13 @@ private void addAncientJavaApiClasses() {
         addLazyFactory("java.awt.color.ICC_Profile", AWT_FACTORY);
         addLazyFactory("java.awt.Font", AWT_FACTORY);
 
+        addFactory(
+                PropertyChangeSupport.class,
+                values(
+                        new PropertyChangeSupport("this"),
+                        new PropertyChangeSupport("that"),
+                        new PropertyChangeSupport("this")));
+
         addLazyFactory("java.rmi.dgc.VMID", RMI_FACTORY);
         addLazyFactory("java.rmi.server.UID", RMI_FACTORY);
     }

diff --git a/src/test/java/nl/jqno/equalsverifier/integration/extended_contract/JavaApiClassesTest.java b/src/test/java/nl/jqno/equalsverifier/integration/extended_contract/JavaApiClassesTest.java
@@ -3,6 +3,7 @@
 import static nl.jqno.equalsverifier.testhelpers.Util.defaultEquals;
 import static nl.jqno.equalsverifier.testhelpers.Util.defaultHashCode;
 
+import java.beans.PropertyChangeSupport;
 import java.io.File;
 import java.lang.reflect.Constructor;
 import java.lang.reflect.Field;
@@ -100,6 +101,13 @@ public void succeed_whenClassContainsStringBuilderThatCallsToStringInEquals() {
                 .verify();
     }
 
+    @Test
+    public void succeed_whenClassContainsClassesButDoesntUseThemInEquals() {
+        EqualsVerifier.forClass(UnusedInEqualsButPresentInClassContainer.class)
+                .suppress(Warning.INHERITED_DIRECTLY_FROM_OBJECT, Warning.ALL_FIELDS_SHOULD_BE_USED)
+                .verify();
+    }
+
     abstract static class CollectionContainer {
 
         protected abstract void callAbstractMethodsOnInterface();
@@ -716,4 +724,12 @@ public int hashCode() {
             return defaultHashCode(this);
         }
     }
+
+    static final class UnusedInEqualsButPresentInClassContainer {
+        private final PropertyChangeSupport pcs;
+
+        public UnusedInEqualsButPresentInClassContainer(PropertyChangeSupport pcs) {
+            this.pcs = pcs;
+        }
+    }
 }