Add opengraph meta tags #3247
Merged
Add opengraph meta tags #3247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itchyny
reviewed
Feb 5, 2025
wader
force-pushed
the
opengraph-tags
branch
2 times, most recently
from
edadd43 to
4e02f5a
Compare
emanuele6
reviewed
Feb 6, 2025
wader
force-pushed
the
opengraph-tags
branch
2 times, most recently
from
31f964b to
0eb49c4
Compare
wader
commented
Feb 6, 2025
docs/templates/shared/_head.html.j2
Outdated
| <meta property="og:description" content="jq is a lightweight and flexible command-line JSON processor"> | ||
| <meta property="og:type" content="website"> | ||
| <meta property="og:image" content="{{ url }}{{ root }}/icon.png"> | ||
| <meta property="og:url" content="{{ url }}{{ root }}/{{ permalink }}"> |
There was a problem hiding this comment.
Ah this should probably not have root, fixing
Makes the site preview a bit nicer when sharing
|
Should we just remove |
|
Never mind, now they are the same :) |
👍 yeah i noticed my own confusion hehe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the site preview a bit nicer when sharing