-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Docker image using pre-built executables #2686
Conversation
CC: "riscv64-linux-gnu" | ||
CC: riscv64-linux-gnu | ||
- arch: s390x | ||
CC: s390x-linux-gnu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorts alphabetically.
- powerpc | ||
- ppc64el | ||
- riscv64 | ||
- s390x |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preference of YAML array.
@@ -97,7 +95,7 @@ jobs: | |||
--with-oniguruma=builtin \ | |||
--enable-static \ | |||
--enable-all-static | |||
make -j$(nproc) | |||
make -j"$(nproc)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For actionlint (shellcheck).
uses: actions/upload-artifact@v3 | ||
with: | ||
name: jq-${{ env.SUFFIX }} | ||
name: jq-linux |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to create artifacts separately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm...I think we may need an explicit |
Thank you! |
As suggested by @userdocs in #2665, I fixed the Docker build job to use the pre-built executables. Also I cleaned up the workflow syntax. The entire workflow was tested here and published here. The docker job runs within 30 seconds (compared to 40 minutes with entire emulation in #2652). BTW, I noticed
ld: warning: option -s is obsolete and being ignored
in macOS build steps. Do we explicitly use the strip or just drop the option? Related PRs: #2665, #2652.