Validate JSON for --jsonarg #2658
Conversation
| fprintf(stderr, "%s: invalid JSON text passed to --jsonargs\n", progname); | ||
| die(); | ||
| } | ||
| ARGS = jv_array_append(ARGS, v); |
There was a problem hiding this comment.
A bit of duplication here. I guess one could extract to some kind of parse_or_die function? could be use for --argjson code also. Maybe for later?
| exit 1 | ||
| fi | ||
| # this tests the args_done code path "--" | ||
| $JQ -n --jsonargs null -- invalid && EC=$? || EC=$? |
There was a problem hiding this comment.
Not sure if this should be exit 2 (usage error?) or invalid input error?
I also noticed that we skip using $VALGRIND is some places, should we fix that?
There was a problem hiding this comment.
We're not very consistent regarding exit status codes. It'd be nice if a) we documented jq's exit codes besides in the -e case, b) maybe made sure that the various usage and system error exit codes differ from the ones for -e?. But that's not for this issue.
And yes, we should fix the non-use of valgrind, but we should do so separately.
|
Thanks! |
Fixes #2572