Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to free in jv_string_indexes #1818

Merged
merged 1 commit into from
Feb 9, 2019
Merged

Make sure to free in jv_string_indexes #1818

merged 1 commit into from
Feb 9, 2019

Conversation

muhmuhten
Copy link
Contributor

2660b04 makes jqtest fail valgrind since it skips the frees when idxlen == 0.

This was kind of an interesting experience when making other changes that could plausibly have leaked memory.

@nicowilliams nicowilliams merged commit 9fa2e51 into jqlang:master Feb 9, 2019
@nicowilliams
Copy link
Contributor

Thanks!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.003%) to 84.485% when pulling 3f59bee on muhmuhten:free_in_index into 88613f5 on stedolan:master.

@muhmuhten muhmuhten deleted the free_in_index branch February 10, 2019 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@muhmuhten @nicowilliams @coveralls