Fix empty regular expression matches (fix #2565)

jqlang · Jul 9, 2023 · 600e602 · 600e602
1 parent cac216a
commit 600e602
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 12 deletions.
diff --git a/src/builtin.c b/src/builtin.c
@@ -1002,7 +1002,7 @@ static jv f_match(jq_state *jq, jv input, jv regex, jv modifiers, jv testmode) {
             jv_string((char*)ebuf)));
       break;
     }
-  } while (global && start != end);
+  } while (global && start <= end);
   onig_region_free(region,1);
   region = NULL;
   if (region)

diff --git a/tests/onig.test b/tests/onig.test
@@ -1,12 +1,16 @@
 # match builtin
 [match("( )*"; "g")]
 "abc"
-[{"offset":0, "length":0, "string":"", "captures":[]},{"offset":1, "length":0, "string":"", "captures":[]},{"offset":2, "length":0, "string":"", "captures":[]}]
+[{"offset":0, "length":0, "string":"", "captures":[]}, {"offset":1, "length":0, "string":"", "captures":[]}, {"offset":2, "length":0, "string":"", "captures":[]}, {"offset":3, "length":0, "string":"", "captures":[]}]
 
 [match("( )*"; "gn")]
 "abc"
 []
 
+[match(""; "g")]
+"ab"
+[{"offset":0,"length":0,"string":"","captures":[]},{"offset":1,"length":0,"string":"","captures":[]},{"offset":2,"length":0,"string":"","captures":[]}]
+
 [match("a"; "gi")]
 "āáàä"
 []
@@ -71,29 +75,27 @@ gsub("a";"b")
 "aaaaa"
 "bbbbb"
 
-gsub( "(.*)"; "";  "x")
+gsub("(.*)"; ""; "x")
 ""
 ""
 
-gsub( ""; "a";  "g")
+gsub(""; "a"; "g")
 ""
 "a"
 
-gsub( "^"; "";  "g")
+gsub("^"; ""; "g")
 "a"
 "a"
 
-
-# The following is a regression test and should not be construed as a requirement other than that execution should terminate:
-gsub( ""; "a";  "g")
+gsub(""; "a"; "g")
 "a"
-"aa"
+"aaa"
 
-gsub( "$"; "a";  "g")
+gsub("$"; "a"; "g")
 "a"
 "aa"
 
-gsub( "^"; "a")
+gsub("^"; "a")
 ""
 "a"
 
@@ -163,5 +165,5 @@ sub("(?<x>.)"; "\(.x)!")
 # splits and _nwise
 [splits("")]
 "ab"
-["","a","b"]
+["","a","b",""]