fixed string parsing bugs around multibyte characters & keyword functions #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -164,8 +155,6 @@ public struct File { | |||
|
|
|||
| :param: dictionary Dictionary to update. | |||
| :param: cursorInfoRequest Cursor.Info request to get declaration information. | |||
|
|
|||
| :returns: An updated copy of the input dictionary with comment mark names and cursor.info information. | |||
There was a problem hiding this comment.
Because it's just a copy-paste of the discussion.
|
This looks fine to me, presuming all tests passed, though I'm not too familiar with the code in question. |
Yeah, I wasn't sure you'd be interested in reviewing this, but figured it didn't hurt to ping you. |
|
👍 |
jpsim
added a commit
that referenced
this pull request
Apr 6, 2015
fixed string parsing bugs around multibyte characters & keyword functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27.
Closes #35.
Starting to port changes & bugfixes from the swift1p2 branch. /cc @segiddins
Since I renamed
NSString+SourceKitten.swifttoString+SourceKitten.swift, you may want to diff locally to see those changes.