Objective-C marks and non-ASCII characters #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -205,9 +234,13 @@ extension String { | |||
| if markString.isEmpty { | |||
| return nil | |||
| } | |||
| let markByteRange = self.NSRangeToByteRange(start: markRange.location, length: markRange.length) | |||
| if markByteRange == nil { | |||
There was a problem hiding this comment.
Fixed in 4243ed8. Thanks for the suggestion.
|
This is really great @1ec5! Thanks for the fix, and especially the nice test case. I'll add a changelog entry to describe the fix and attribute you, but that's something you should do yourself next time! |
jpsim
added a commit
that referenced
this pull request
Dec 9, 2015
Objective-C marks and non-ASCII characters
jpsim
added a commit
that referenced
this pull request
Dec 9, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #114.