This repository has been archived by the owner on Nov 10, 2023. It is now read-only.
Bluetooth Playback fix and ExactJump near min/max fix #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…your app to record, you can simply use the setSessionCatagory: message to set back to PlayAndRecord. But, as it was before this commit, playback is stopped over bluetooth immediately, even if I change it to Playback, it doesn’t start playing again. @samyes Take note of this change
…. The feature will now allow jumps to 0 or 1 to allow for working with button presses when the volume is near max/min.
|
I have tested this PR and don't see any problems, it definitely fixes problems with Bluetooth Audio streaming. |
|
Ok, confirmation from two users that this works for them is a good start to ensure QA. Do either of you need a tagged release for this? |
|
I don't need it tagged, I just have a sub-module, not a huge fan of cocoa pods myself |
|
Thanks but I will just reference the commit until a new version comes out. |
|
@jpsim I’m using this from Cocoapods, would it possible to get a new release for this? I’m currently on |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46 We must default to the Playback Category. If you want your app to record, you can simply use the setSessionCatagory: message to set back to PlayAndRecord. But, as it was before this commit, playback is stopped over bluetooth immediately, even if I change it to Playback, it doesn’t start playing again. @samyes and @CallumOz Take note of this change
Fixes an issue with my last PR and the exactJumpsOnly Feature I added
The feature will now allow jumps to 0 or 1 to allow for working with button presses when the volume is near max/min.