-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #220: npm audit returns 23 vulnerabilities (11 low, 8 high, 4 critical) #221
Open
chezearth
wants to merge
16
commits into
jprichardson:master
Choose a base branch
from
chezearth:address-npm-vulnerabilities
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix for issue #220: npm audit returns 23 vulnerabilities (11 low, 8 high, 4 critical) #221
chezearth
wants to merge
16
commits into
jprichardson:master
from
chezearth:address-npm-vulnerabilities
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to gulp-bro, updated minify and uglify
…earth/string.js into address-npm-vulnerabilities
Thanks for the PR @chezearth. I will have a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can see what I've done here from the commit history. I advanced the version patch just for my own reference -- not sure these changes warrant it. The updated packages only seemed to break the gulpfile (as Gulp itself jumped big) and the tests (as Mocha jumped too). On my Mac Growl throws an error if the notifier isn't installed, which causes Mocha to do the same. I tried but couldn't find a way to test for the notifier before deciding whether to include
growl: 1
in the argument for themocha()
method. Tests ran fine -- I will try and work on some new ones when I get some bandwidth.