-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reverse method #124
base: master
Are you sure you want to change the base?
Add reverse method #124
Conversation
I reverted the minified file based on your comment on #88 |
Thank you! Would you be willing to update the README as well with the new method? Thanks again! |
Of course; sorry! I accidentally stripped some trailing whitespace--hope that's okay. I also dorked and this change is on my master branch, but that should be ok. |
Thank you.
No problem. Ok, I'm not sure how I feel about the |
I agree @jprichardson for null and undefined it should either be ' ' or throw an error. As for |
…ring, arrays and objects return what you'd expect
The I updated |
Fair enough. What do you think should be the case for |
Not sure. My only concern is that letting a At the same time, I'm pretty ambivalent. |
Sorry for the necro post. Personally, I think that returning |
Oh I'd forgotten all about this. Still, if the functionality hasn't been added yet, can someone make an executive decision on handling this and merge it in? |
Used following as reference to choose the simplest method which is generally fast.
Feel free to override that decision.