Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run copy*() filter before running fs.stat() on items #971

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

RyanZim
Copy link
Collaborator

@RyanZim RyanZim commented Oct 21, 2022

Fixes #965 cc @c-vetter

Exact approach in nodejs/node#44922 didn't seem appropriate.

@RyanZim RyanZim added this to the 11.0.0 milestone Oct 21, 2022
@RyanZim RyanZim requested review from JPeer264 and manidlou October 21, 2022 00:17
@RyanZim RyanZim marked this pull request as ready for review October 28, 2022 19:09
@RyanZim RyanZim merged commit b3146f0 into master Oct 31, 2022
@RyanZim RyanZim deleted the ryan/filter-before-stat branch October 31, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [copy] filtered-out items get statted, leading to unrecoverable exception
1 participant