Fixes fs-extra on linux #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repository owner
deleted a comment from
coveralls
Nov 17, 2017
|
@arcanis Thanks for the PR. What kind of Linux are you running when you get this error? What filesystem? I'm on Linux myself, but I've never had this problem, though I can see it could happen, looking at the Node.js code. |
RyanZim
reviewed
Nov 17, 2017
lib/fs/index.js
Outdated
| // Some commands are not available on some systems. Ex: | ||
| // fs.copyFile was added in Node.js v8.5.0 | ||
| // fs.mkdtemp was added in Node.js v5.10.0 | ||
| // fs.lchown is not available on Linux |
There was a problem hiding this comment.
// fs.lchown is not available on some computers
It isn't unavailable on all Linux.
lib/fs/index.js
Outdated
| // fs.copyFile was added in Node.js v8.5.0 | ||
| // fs.mkdtemp was added in Node.js v5.10.0 | ||
| // fs.lchown is not available on Linux | ||
| return fs[key] |
There was a problem hiding this comment.
Just for consistency with the previous code, to prevent possible regressions, can we change this to
return typeof fs[key] === 'function'
?
|
Also, please squash into one commit. |
|
I'm not too sure. I think O_SYMLINK is supposed to only be present on BSD-based systems, at least according to nodejs/node-v0.x-archive#3598 and nodejs/node-v0.x-archive#2142 (comment). Will make the requested changes. |
Repository owner
deleted a comment from
coveralls
Nov 18, 2017
RyanZim
approved these changes
Nov 18, 2017
jprichardson
approved these changes
Nov 18, 2017
manidlou
approved these changes
Nov 18, 2017
|
@arcanis Thanks! |
This was referenced Dec 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
lchownfunction is not available on some systems. Usingfs-extrathere causes a crash:This PR makes sure that all commands exist before trying to convert them.