ensure for link & symlink

[reggi]

No description provided.

[reggi]

@jprichardson

Added:

• error messages use lstat and replace the string lstat with ensureSymlink and ensureLink respectivley
• will not create recursive destination directories on error
• branched out feature and dev so you can see diffs between pull-requests here

[reggi]

Should an error be thrown if the destination path exists?

[jprichardson]

Should an error be thrown if the destination path exists?

I don't think so.

Thanks for your hard work on this, I really appreciate it! Published 0.23.0.

[reggi]

The functions currently return an error for async and throw for sync if the destination path exists because that's the native functionality of fs.link and fs.symlink is exposed.

[jprichardson]

Yeah, I think that they should be normalized to not throw errors if the destination exists. I mean, the intent of the caller of these methods is to just make sure that they exist regardless of whether they existed before said method was called. Don't you think?

[reggi]

As expressed here I feel weird throwing the err away. My current usage for this function is as follows, please forgive the promises.

fse.ensureLinkAsync(pkg.main, paths.mainDst)
.then(debugThen('linking main %s -> %s', pkg.main, paths.mainDst)).catch(debugCatch),

So for control-flow it's useful to know if something has been created or not.

Thats why I expressed the need for ensureWarn functions.

I agree though with this:

the intent of the caller of these methods is to just make sure that they exist regardless

Crafting PR(s) now.

[reggi]

#169