Unclosed file handle on futimes error

[chadnickbok]

The call to fs.close(fd) should be performed before the call to return in this function:

https://github.com/jprichardson/node-fs-extra/blob/master/lib/util/utimes.js#L53

[hhamilto]

Unless anyone is working on this, I'll submit a PR.

[jprichardson]

Unless anyone is working on this, I'll submit a PR.

Would love this. Please include a test. Thanks!

[hhamilto]

Please include a test.

Will do. I think there might be a few different ways to test this, so once the PR is up, I'll welcome some feed back on the best approach.

[hhamilto]

@jprichardson Question:
How do you feel about adding a devDependency on Sinon, or some other mocking library?

Background:
I'm thinking that mocking would be the best way to test that close is properly called even when the call to futimes returns an error. The only errors that futimes usually returns occur when the fd passed in refers to a file on a read-only file system, or if the owner of the file doesn't match the current user (from here). It doesn't seem practical to set up either of these conditions just for a test, unless I missed something when researching.

If we mocked the fs functions that utimesMillis uses, then we could just assert that the close method is called even when futimes returns an error.

[jprichardson]

@hhamilto how do you feel about proxyquire?

[RyanZim]

@hhamilto How's that PR coming along?

[hhamilto]

@ryan I'd welcome your feedback on it:
#289

[RyanZim]

Sorry, didn't realize a PR was filed.

[hhamilto]

No worries, I meant to put a ping on it a while back, to see if there is anything else that needs to be fixed before it gets merged.