Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More small fixes #2263

Merged
merged 11 commits into from
Jan 20, 2023
5 changes: 5 additions & 0 deletions .changeset/light-countries-report.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-modular-react-app': major
---

Bumped default TypeScript version to ^4.8.3
4 changes: 2 additions & 2 deletions .github/workflows/static.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,9 @@ name: Lint

on:
push:
branches: [main, 'release/**', feature/v4]
branches: [main, 'release/**']
pull_request:
branches: [main, 'release/**', feature/v4]
branches: [main, 'release/**']

jobs:
Static:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ name: Windows Test

on:
push:
branches: [main, 'release/**', feature/v4]
branches: [main, 'release/**']
pull_request:
branches: [main, 'release/**', feature/v4]
branches: [main, 'release/**']

jobs:
Test:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ name: Test

on:
push:
branches: [main, 'release/**', feature/v4]
branches: [main, 'release/**']
pull_request:
branches: [main, 'release/**', feature/v4]
branches: [main, 'release/**']

jobs:
Test:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/validate.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
name: 'Validate'
on:
push:
branches: [main, 'release/**', feature/v4]
branches: [main, 'release/**']
pull_request:
branches: [main, 'release/**', feature/v4]
branches: [main, 'release/**']

jobs:
check-yarn-lock-registry:
Expand Down
1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@
"execa": "5.1.1",
"husky": "8.0.1",
"is-ci": "2.0.0",
"jest-environment-jsdom": "^29.3.1",
"lint-staged": "12.4.1",
"micromatch": "4.0.5",
"patch-package": "^6.4.7",
Expand Down
2 changes: 1 addition & 1 deletion packages/create-modular-react-app/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ export default async function createModularApp(argv: {
'prettier',
'modular-scripts',
'eslint-config-modular-app',
'typescript@>=4.2.1 <4.5.0',
'typescript@^4.8.3',
],
newModularRoot,
// We can't pass a stream here if it's not backed by a fd. We need to set it to 'pipe', then pipe it from the ChildProcess to our transformer
Expand Down
1 change: 1 addition & 0 deletions packages/modular-scripts/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
"jest-circus": "^29.0.0",
"jest-cli": "^29.0.0",
"jest-config": "^29.0.0",
"jest-environment-jsdom": "^29.3.1",
"jest-runner-eslint": "1.1.0",
"jest-transform-stub": "2.0.0",
"jest-watch-typeahead": "^2.0.0",
Expand Down
2 changes: 1 addition & 1 deletion packages/modular-scripts/src/addPackage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ async function addPackage({
paths: [modularRoot],
});
} catch (e) {
console.log(e);
logger.log(`Couldn't find ${templateName} in project`);
logger.log(
`Installing template package ${templateName} from registry, this may take a moment...`,
);
Expand Down