-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user settings to frontend, use them to configure FSContentsManager on the backend #21
Merged
timkpaine
merged 38 commits into
jpmorganchase:master
from
telamonian:setup-pyfs-via-user-settings
May 4, 2020
Merged
Add user settings to frontend, use them to configure FSContentsManager on the backend #21
timkpaine
merged 38 commits into
jpmorganchase:master
from
telamonian:setup-pyfs-via-user-settings
May 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4df170f
to
640af76
Compare
00f9dd3
to
ebae9c7
Compare
9bd9c92
to
2632468
Compare
2632468
to
f1cf1ea
Compare
- also picked lint in utils.ts
- refactored other names in jupyterfs to match - still need to do the actual file renames
timkpaine
approved these changes
May 4, 2020
timkpaine
added a commit
to timkpaine/jupyter-fs
that referenced
this pull request
Aug 13, 2023
JPM Omnibus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #22
In this PR I will:
create user settings for jupyter-fs
specs
field that holds a list ofspec
(as in "filesystem specification") objects:ship list of resources to backend
dynamically initialize multiple fs contents instances on the server backend based on the list of resources provided by the frontend
ship list of initialized resources to frontend
dynamically initalize multiple FileTree on the frontend based the list of initalized resources provided by the backend
glue all of the above together
work out various kinks and bugs in FileTree/improve FileTree UI
update the README to reflect all of the above