Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user settings to frontend, use them to configure FSContentsManager on the backend #21

Merged

Conversation

telamonian
Copy link
Contributor

@telamonian telamonian commented Apr 22, 2020

fixes: #22

In this PR I will:

  • create user settings for jupyter-fs

    • top level specs field that holds a list of spec (as in "filesystem specification") objects:
      "specs": [
        {
          "name": "osfs_test";
          "url": "osfs:///Users/foo/whatever";
        },
        ...
      ]
  • ship list of resources to backend

  • dynamically initialize multiple fs contents instances on the server backend based on the list of resources provided by the frontend

  • ship list of initialized resources to frontend

  • dynamically initalize multiple FileTree on the frontend based the list of initalized resources provided by the backend

  • glue all of the above together

  • work out various kinks and bugs in FileTree/improve FileTree UI

  • update the README to reflect all of the above

@telamonian telamonian force-pushed the setup-pyfs-via-user-settings branch from 4df170f to 640af76 Compare April 22, 2020 10:15
@telamonian telamonian force-pushed the setup-pyfs-via-user-settings branch from 00f9dd3 to ebae9c7 Compare April 26, 2020 23:16
@telamonian telamonian changed the title Add user settings to frontend, use them to configure FSContentsManager on the backend [WIP] Add user settings to frontend, use them to configure FSContentsManager on the backend Apr 27, 2020
@telamonian telamonian force-pushed the setup-pyfs-via-user-settings branch 4 times, most recently from 9bd9c92 to 2632468 Compare April 27, 2020 09:01
@telamonian telamonian force-pushed the setup-pyfs-via-user-settings branch from 2632468 to f1cf1ea Compare April 27, 2020 09:23
@telamonian
Copy link
Contributor Author

It's done!

image

The final version of this PR covers everything mentioned in the top post, and a bit more. Lots of misc fixes and improvements.

@telamonian telamonian changed the title [WIP] Add user settings to frontend, use them to configure FSContentsManager on the backend Add user settings to frontend, use them to configure FSContentsManager on the backend May 4, 2020
@telamonian telamonian requested a review from timkpaine May 4, 2020 13:03
@timkpaine timkpaine merged commit 8101c4f into jpmorganchase:master May 4, 2020
@telamonian telamonian added this to the 0.0.2 milestone May 6, 2020
timkpaine added a commit to timkpaine/jupyter-fs that referenced this pull request Aug 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Name of PyFilesystemContentsManager is too long
2 participants