-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
purge filetree, clean up a few misc items #108
Conversation
I see that the jupyterlab-filetree code was copied there, would you like a PR to jupyter-fs directly? Do you think we should copy the code or should we install the federated extension with pip/conda? |
damn right we should. Very sadly just adding the new Other options:
Anyway, the last time I thought about this I essentially threw up my hands and decided it was a documentation problem. The options are not great |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I rebased this onto lastest main and also got rid of the change to the config file
@martinRenou I think there's 4 practical options to deal with this:
Option 2) is probably the best (at least in terms of what problems it can cause), and in any case it may make good engineering sense to structure your project as separate lib and extension pkgs. If it doesn't make sense to split up your project that way, then 3) is the better fallback; vended code tends to cause heartbreak the moment it gets out of sync with its HEAD. |
filetree
from the code base, this should allow @martinRenou to PR his file tree fork upstream