Add transformer entry point #116
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
UP |
…hub.com:christophe-rannou/jpmml-evaluator into feature/preprocessor-entry-point
vruusmann
reviewed
Jan 28, 2019
| @@ -66,6 +61,11 @@ private FieldValue declareMissing(FieldName name) { | |||
| return declare(name, (FieldValue) null); | |||
| } | |||
|
|
|||
| @Override | |||
| protected FieldValue prepare(FieldName name, Object value) { | |||
| throw new NotImplementedException(); | |||
There was a problem hiding this comment.
Should be java.lang.UnsupportedOperationException instead.
The org.jpmml.evaluator.NotImplementedException has a different meaning - "the PMML specification defines some feature/nehaviour, but this is not yet implemented in the JPMML-Evaluator library"
|
What's the use case for 64-bit integer values? Counting milliseconds since 01-01-1970? Please comment here: #141 |
…hub.com:christophe-rannou/jpmml-evaluator into feature/preprocessor-entry-point
|
Duplicate of #96 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#96