-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix two minor issues with the Java language module token extraction #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d variable initialization.
…okens for try and finally.
tsaglam
added
bug
Issue/PR that involves a bug
minor
Minor issue/feature/contribution/change
language
PR / Issue deals (partly) with new and/or existing languages for JPlag
labels
Feb 17, 2023
tsaglam
changed the title
Fix three issues with the Java language module token extraction
Fix three minor issues with the Java language module token extraction
Feb 17, 2023
tsaglam
force-pushed
the
feature/java-try
branch
from
February 20, 2023 10:02
1cf7606
to
4e004fb
Compare
tsaglam
changed the title
Fix three minor issues with the Java language module token extraction
Fix two minor issues with the Java language module token extraction
Feb 20, 2023
Kudos, SonarCloud Quality Gate passed! |
@mbrdl @SirYwell just FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
threetwo issues with the token extraction:Initialization and subsequent declaration of a variable in a single line vs. two line lead to different tokensEDIT: Removed the last fix, as it affected the false positives enough while not affecting the true-positives significantly
This PR does not affect the E2E tests, as try/catch-blocks are not part of the dataset used there.