Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up dependencies of the core project #938

Merged
merged 2 commits into from
Feb 16, 2023
Merged

Clean-up dependencies of the core project #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4081c2
Remove superfluous token printer test cases.
tsaglam Feb 16, 2023
e76c4a7
Remove dependencies on language modules that are not really required.
tsaglam Feb 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 1 addition & 42 deletions core/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,54 +25,13 @@
<artifactId>language-api</artifactId>
<version>${revision}</version>
</dependency>
<!-- the core project only requires one language module for testing: -->
<dependency>
<groupId>de.jplag</groupId>
<artifactId>java</artifactId>
<version>${revision}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>de.jplag</groupId>
<artifactId>cpp</artifactId>
<version>${revision}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>de.jplag</groupId>
<artifactId>rlang</artifactId>
<version>${revision}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>de.jplag</groupId>
<artifactId>golang</artifactId>
<version>${revision}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>de.jplag</groupId>
<artifactId>scala</artifactId>
<version>${revision}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>de.jplag</groupId>
<artifactId>kotlin</artifactId>
<version>${revision}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>de.jplag</groupId>
<artifactId>emf-metamodel</artifactId>
<version>${revision}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>de.jplag</groupId>
<artifactId>emf-metamodel-dynamic</artifactId>
<version>${revision}</version>
<scope>test</scope>
</dependency>
</dependencies>

<build>
Expand Down
26 changes: 1 addition & 25 deletions core/src/test/java/de/jplag/special/TokenPrinterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,36 +25,12 @@ class TokenPrinterTest extends TestBase {
private static final int MIN_TOKEN_MATCH = 5;
private static final String PRINTER_FOLDER = "PRINTER"; // in the folder 'jplag/src/test/resources/samples'

@Disabled("Not a meaningful test, used for designing the token set")
@Test
void printCPPFiles() {
printSubmissions(options -> options.withLanguageOption(new de.jplag.cpp.Language()).withMinimumTokenMatch(MIN_TOKEN_MATCH));
}

@Disabled("Not a meaningful test, used for designing the token set")
@Disabled("Not a meaningful test, used for designing the token set. Can be implemented for other languages.")
@Test
void printJavaFiles() {
printSubmissions(options -> options.withMinimumTokenMatch(MIN_TOKEN_MATCH));
}

@Disabled("Not a meaningful test, used for designing the token set")
@Test
void printRLangFiles() {
printSubmissions(options -> options.withLanguageOption(new de.jplag.rlang.Language()).withMinimumTokenMatch(MIN_TOKEN_MATCH));
}

@Disabled("Not a meaningful test, used for designing the token set")
@Test
void printGoFiles() {
printSubmissions(options -> options.withLanguageOption(new de.jplag.golang.Language()));
}

@Disabled("Not a meaningful test, used for designing the token set")
@Test
void printKotlinFiles() {
printSubmissions(options -> options.withLanguageOption(new de.jplag.kotlin.Language()));
}

private void printSubmissions(Function<JPlagOptions, JPlagOptions> optionsCustomization) {
try {
JPlagResult result = runJPlag(PRINTER_FOLDER, optionsCustomization);
Expand Down