Enhance/add error page if overview or comparison missing #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if-some-comparisions-missing
…if-some-comparisions-missing
…r-page-if-overview-missing
…if-some-comparisions-missing
…if-some-comparisions-missing
…r-page-if-overview-or-comparison-missing
…instead of three variables)
tsaglam
added
enhancement
59 tasks
|
@cyfml Please update this PR on the current state, then I will have look at the changes and review it |
|
Kudos, SonarCloud Quality Gate passed! |
sebinside
approved these changes
Feb 13, 2023
65 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handels an error : report-viewer is broken when overview or some comparisons are missing. I create an
ErrorViewpage, which containsErrorMessageandErrorRoutercomponents.Overview missing: error page has a button, which can navigate to
FileUploadView.Some certain comparisons missing: overview page works continually and can access other comparisons which are not missing. If access missing comparisons, it will navigate to
OverviewView.Note: In comparison missing cases, If you decompress the zip file and delete some comparisons. Then re-compress them. It leads a problem: when you click a match in
MatchTable, it will not scroll to corresponding position automatically and matched codes have no color. The reason is when you decompress and recompress files, the variableoriginalFileNameinFileUploadViewchanges for files under 'files' directory. e.g. From "files\A\GSTiling.java" to "files/A/GSTiling.java". So the name of file inMatchTableis not same as file header incodelPanel. If you delete comparisons directly in zip file, there is no problem. This problem only occurs on windows, beacuse It seems zip app uses default path separator '/'. So this zip file are not allowed be decompressed and recompressed on windows. If you want to delete something, please delete it directly in zip file and don't decompress and recompress.