Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zip Report Viewer Files #588

Closed
wants to merge 16 commits into from
Closed

Zip Report Viewer Files #588

wants to merge 16 commits into from

Conversation

nestabentum
Copy link
Contributor

Builds upon PR #569 and should not be merged before it. Only the changes from commit 7981390 are relevant.

Zips the folder containing the report viewer files. Deletes the unzipped version, given zipping was successful.

@nestabentum
Replace / in submission Names with _
bc17359
@nestabentum
Write SubmissionNames as Tuple of ID and DisplayName
31b51b7
@nestabentum
Use Lookup Table to Associate ComparisonFileName to SubmissionFileNames
cd22e25
@nestabentum
Adapt report viewer to use submission Ids
6994a63 
IDs for internal use, display name for displaying the submission name.
@nestabentum
Use SubmissionId-To-Comparison-Map in ReportViewer
14e1bc4
@nestabentum
Use Numbers as ComparisonFile Names
d62ddb1
@nestabentum
Cleanup & Add JavaDoc
0cf15d2
@nestabentum
Revert "Use Numbers as ComparisonFile Names"
2eee856 
This reverts commit 7feae1e
@nestabentum
Use Concatenation of Submission IDs for Comparison Name
5c23078
@nestabentum
Rename OverviewReport fields
95d4b43
@nestabentum
Delete unused OverviewReport Field
7d39689
@nestabentum
Fix Anonymization
8a6657e
@nestabentum
Improve Exception Handling
abc3544
@nestabentum
Improve ComparisonReportWriterTest
41d5e41
@nestabentum
Zip Report Viewer Files
7981390
@sebinside sebinside self-requested a review August 12, 2022 06:59
@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Aug 12, 2022
@tsaglam tsaglam requested review from a team August 12, 2022 07:10
dfuchss
dfuchss reviewed Aug 12, 2022
View reviewed changes
Copy link
Member

@dfuchss dfuchss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor remark

jplag/src/main/java/de/jplag/reporting/jsonfactory/DirectoryManager.java Show resolved Hide resolved
sebinside
sebinside approved these changes Aug 12, 2022
View reviewed changes
Copy link
Member

@sebinside sebinside left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this on windows 10 with a set of 40.000 comparisons, and it worked fine (although it took some time). Hint: Don't try to use the Report Viewer with 40.000 files, it obviously crashes :)

jplag/src/main/java/de/jplag/reporting/reportobject/ReportObjectFactory.java Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

34.6% 34.6% Coverage
0.0% 0.0% Duplication

@tsaglam
Copy link
Member

tsaglam commented Aug 23, 2022

@nestabentum, some conflicts need to be solved here before we can proceed.

@nestabentum nestabentum mentioned this pull request Aug 23, 2022
Merged
@nestabentum
Copy link
Contributor Author

Clean and ready to merge version is #608

@tsaglam tsaglam removed the request for review from a team August 23, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanWittler JanWittler JanWittler left review comments

@dfuchss dfuchss dfuchss left review comments

@sebinside sebinside sebinside approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
No open projects
v4.0.0 Release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nestabentum @tsaglam @sebinside @dfuchss @JanWittler