Add Rust frontend #585
Merged
Add Rust frontend #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pom.xml
# Conflicts: # README.md # jplag.cli/pom.xml # jplag/src/main/java/de/jplag/options/LanguageOption.java # pom.xml
# Conflicts: # README.md
tsaglam
added
enhancement
tsaglam
requested changes
Aug 15, 2022
jplag.frontend.rust/src/main/java/de/jplag/rust/JplagRustListener.java
Outdated
Show resolved
Hide resolved
jplag.frontend.rust/src/main/java/de/jplag/rust/JplagRustListener.java
Outdated
Show resolved
Hide resolved
jplag.frontend.rust/src/main/java/de/jplag/rust/JplagRustListener.java
Outdated
Show resolved
Hide resolved
JanWittler
reviewed
Aug 15, 2022
jplag.frontend.rust/src/main/java/de/jplag/rust/RustTokenConstants.java
Outdated
Show resolved
Hide resolved
jplag.frontend.rust/src/main/java/de/jplag/rust/ParserState.java
Outdated
Show resolved
Hide resolved
jplag.frontend.rust/src/main/java/de/jplag/rust/ParserState.java
Outdated
Show resolved
Hide resolved
jplag.frontend.rust/src/main/java/de/jplag/rust/ParserState.java
Outdated
Show resolved
Hide resolved
dfuchss
reviewed
Aug 16, 2022
jplag.frontend.rust/src/main/java/de/jplag/rust/grammar/RustLexerBase.java
Outdated
Show resolved
Hide resolved
tsaglam
approved these changes
Aug 19, 2022
|
The code smells are acceptable for my part. Should be ready to merge. |
tsaglam
reviewed
Aug 24, 2022
There was a problem hiding this comment.
@robinmaisch one final request: Could you update the newly added language table in the project readme? Either here or in a separate PR.
|
Kudos, SonarCloud Quality Gate passed! |
Ah, sure! There you go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a Rust frontend to JPlag. Its design is similar to the other frontends based on ANTLR4.
Some challenges regarding the syntax of Rust and its formulation in the ANTLR4 grammar are discussed in the README.
To the best of my understanding, it now produces consistent, correct TokenLists. Still, this frontend may very well be subject to further redesign in the future.
Adressing #345 and completing the set of frontends proposed there.