Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kotlin frontend #475

Merged
merged 19 commits into from
Jul 25, 2022
Merged

Add Kotlin frontend #475

merged 19 commits into from
Jul 25, 2022

Conversation

robinmaisch
Copy link
Contributor

@robinmaisch robinmaisch commented Jun 29, 2022

This PR introduces a Kotlin frontend to JPlag. Its structure is very similar to the C# and R frontends.
It comes with a README, some basic tests, and some test code in written in Kotlin.

Also, the README of the top module is updated to reflect the new CLI language options.

Addressing #345.

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change language PR / Issue deals (partly) with new and/or existing languages for JPlag labels Jun 29, 2022
@tsaglam tsaglam added this to the v4.0.0 milestone Jun 29, 2022
@tsaglam tsaglam requested review from tsaglam, a team and JanWittler June 30, 2022 12:06
@robinmaisch
Copy link
Contributor Author

robinmaisch commented Jul 4, 2022

@tsaglam In order to simplify the differentiation of types of blocks, do you think it is okay to modify the grammar a bit?

@tsaglam
Copy link
Member

tsaglam commented Jul 4, 2022

In order to simplify the differentiation of types of blocks, do you think it is okay to modify the grammar a bit?

@robinmaisch yes, but please document your changes somewhere, probably in the frontend readme. Also, check the grammar license, some licenses do not allow modification, even though this is probably not the case here.

@@ -48,7 +48,7 @@ Usage: JPlag [ options ] [ <root-dir> ... ] [ -new <new-dir> ... ] [ -old <old-d

named arguments:
-h, --help show this help message and exit
-l {java,python3,cpp,csharp,char,text,scheme} Select the language to parse the submissions (default: java)
-l {java,python3,cpp,csharp,rlang,kotlin,char,text,scheme} Select the language to parse the submissions (default: java)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@SuyDesignz SuyDesignz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes mainly include uniformities to other languages or to naming conventions

@@ -48,7 +48,7 @@ Usage: JPlag [ options ] [ <root-dir> ... ] [ -new <new-dir> ... ] [ -old <old-d

named arguments:
-h, --help show this help message and exit
-l {java,python3,cpp,csharp,char,text,scheme} Select the language to parse the submissions (default: java)
-l {java,python3,cpp,csharp,rlang,kotlin,char,text,scheme} Select the language to parse the submissions (default: java)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move added "rlang" to different PR
Was it probably forgotten in the R frontend? If so, I would just leave it in since R language has already been processed .

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I thought. Luckily, this is only text and no functional part that was missed.

jplag.frontend.kotlin/pom.xml Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
4.2% 4.2% Duplication

@tsaglam tsaglam merged commit 7506ae0 into jplag:master Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes language PR / Issue deals (partly) with new and/or existing languages for JPlag minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants