-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kotlin frontend #475
Add Kotlin frontend #475
Conversation
…or remaining token types, add Kotlin test file
@tsaglam In order to simplify the differentiation of types of blocks, do you think it is okay to modify the grammar a bit? |
@robinmaisch yes, but please document your changes somewhere, probably in the frontend readme. Also, check the grammar license, some licenses do not allow modification, even though this is probably not the case here. |
jplag.frontend.kotlin/src/main/java/de/jplag/kotlin/KotlinListener.java
Outdated
Show resolved
Hide resolved
@@ -48,7 +48,7 @@ Usage: JPlag [ options ] [ <root-dir> ... ] [ -new <new-dir> ... ] [ -old <old-d | |||
|
|||
named arguments: | |||
-h, --help show this help message and exit | |||
-l {java,python3,cpp,csharp,char,text,scheme} Select the language to parse the submissions (default: java) | |||
-l {java,python3,cpp,csharp,rlang,kotlin,char,text,scheme} Select the language to parse the submissions (default: java) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposed changes mainly include uniformities to other languages or to naming conventions
@@ -48,7 +48,7 @@ Usage: JPlag [ options ] [ <root-dir> ... ] [ -new <new-dir> ... ] [ -old <old-d | |||
|
|||
named arguments: | |||
-h, --help show this help message and exit | |||
-l {java,python3,cpp,csharp,char,text,scheme} Select the language to parse the submissions (default: java) | |||
-l {java,python3,cpp,csharp,rlang,kotlin,char,text,scheme} Select the language to parse the submissions (default: java) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move added "rlang" to different PR
Was it probably forgotten in the R frontend? If so, I would just leave it in since R language has already been processed .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is what I thought. Luckily, this is only text and no functional part that was missed.
jplag.frontend.kotlin/src/main/java/de/jplag/kotlin/KotlinListener.java
Outdated
Show resolved
Hide resolved
jplag.frontend.kotlin/src/test/java/de/jplag/kotlin/KotlinFrontendTest.java
Outdated
Show resolved
Hide resolved
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
This PR introduces a Kotlin frontend to JPlag. Its structure is very similar to the C# and R frontends.
It comes with a README, some basic tests, and some test code in written in Kotlin.
Also, the README of the top module is updated to reflect the new CLI language options.
Addressing #345.