Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write Clusters To JSON Report #453

Merged
merged 3 commits into from
Jun 25, 2022
Merged

Write Clusters To JSON Report #453

merged 3 commits into from
Jun 25, 2022

Conversation

nestabentum
Copy link
Contributor

Implementation of the upper most bullet point from #357.

  • Adds averageSimilarity as an attribute to the Cluster class.
  • In report creation clustering info is now included
  • Removed ClusteringRealDataTest.java because of its limited use

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies labels Jun 10, 2022
@tsaglam tsaglam added this to the v4.0.0 milestone Jun 10, 2022
@tsaglam tsaglam requested review from a team and sebinside June 10, 2022 13:31
tsaglam
tsaglam requested changes Jun 20, 2022
View reviewed changes
Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one small thing.

jplag/src/main/java/de/jplag/clustering/Cluster.java Show resolved Hide resolved
jplag/src/main/java/de/jplag/reporting/reportobject/model/Cluster.java Show resolved Hide resolved
@tsaglam tsaglam merged commit 6a7ba9b into jplag:master Jun 25, 2022
@sebinside sebinside removed their request for review June 30, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinmaisch robinmaisch robinmaisch left review comments

@tsaglam tsaglam tsaglam approved these changes

Assignees
No one assigned
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@nestabentum @tsaglam @robinmaisch