Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add R language frontend #451

Closed
wants to merge 11 commits into from
Closed

Add R language frontend #451

wants to merge 11 commits into from

Conversation

robinmaisch
Copy link
Contributor

Let's add R to JPlag! The R branch should be perfectly runnable.
If there is any trouble or suggestions, let me know.

Adressing Issues #75 #345

@tsaglam
Copy link
Member

tsaglam commented Jun 9, 2022

@robinmaisch currently, this PR contains multiple newly added frontends. I would suggest one frontend per PR. This would include a short readme in the frontend and some test cases. Any other changes should be explained and well-argued for in the PR description. E.g. changes to the token printer. For the PR description, try to point out what you changed/added and why. Smaller bug fixes, like the fix in the ErrorConsumer, should be another small PR.

@robinmaisch
Copy link
Contributor Author

Got it, I'll work on these points right away.

@robinmaisch robinmaisch deleted the R branch June 10, 2022 10:32
@robinmaisch
Copy link
Contributor Author

@tsaglam In a new frontend, are the tests supposed to be disabled, like the tests in MinimalCSharpFrontendTest?

@tsaglam
Copy link
Member

tsaglam commented Jun 14, 2022

No, they should be enabled. When you design meaningful tests (as we discussed recently), they should be enabled by default.
The MinimalCSharpFrontendTest should not be disabled afaik.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants