Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move non generic frontend-utils code into their respective frontends #275

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

GabrielL
Copy link
Contributor

in frontend-utils, there is some classes that are only used by a specific frontend:

  • NewlineStream is used by cpp
  • UnicodeReader by csharp
  • InputState & ParserToken only by text

This small change move them out of frontend-utils and into their respective packages

Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution!

@tsaglam tsaglam merged commit fdf6246 into jplag:master Jan 19, 2022
@tsaglam tsaglam added this to the v3.1.0 milestone Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants