Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix close pr workflow closing wrong issues #1748

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented May 3, 2024

The workflow that closes issues, closes issues with sub-starting numbers (e.g. Issue is #1234, it closes #1, #12,...)

Fixed by having check that after the last number, comes a non number. To ensure this works for the end of the text, we append a placeholder symbol (a dot)

@Kr0nox Kr0nox requested a review from a team May 3, 2024 08:06
@Kr0nox Kr0nox added the github_actions Pull requests that update GitHub Actions code label May 3, 2024
@Kr0nox Kr0nox changed the title Fix close pr workflow closing work issues Fix close pr workflow closing wrong issues May 3, 2024
@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels May 3, 2024
@tsaglam tsaglam merged commit 2312b70 into develop May 3, 2024
@tsaglam tsaglam deleted the fix-dev-close-workflow branch May 3, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug github_actions Pull requests that update GitHub Actions code minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants