Character precise matches #1695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kr0nox
added
enhancement
|
|
tsaglam
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously JPlag could only display matches per line. This made it difficult to see where some matches ended and could even hide matches entirely.
This PR adds information to the report and displays it, so matches are highlighted character precise.
This PR is backwards compatible with 5.0.0
When writing the comparison report, JPlag now adds information about the start and end column to each match.
The report viewer reads that information and saves it. Code displaying was reworked, so that each line is now its own component. This component calculates which parts of the line need to be highlighted accordingly.
The columns might not be calculated correctly in some language modules, that save start and length not correctly when parsing.