Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed the result-directory option to result-file #1566

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

TwoOfTwelve
Copy link
Contributor

@TwoOfTwelve TwoOfTwelve commented Feb 16, 2024

The -r option is now called --result-file instead of --result-directory. This is, because JPlag does not interpret this option as a directory. To fit this, the code handling it has been updated to reflect this. Missing .zip endings will now be automatically added/ommited when using -r.

@tsaglam tsaglam added enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change labels Feb 16, 2024
@tsaglam tsaglam added this to the v5.0.0 milestone Feb 16, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues

Measures
0 Security Hotspots
29.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one meta issue.

cli/src/main/java/de/jplag/cli/CLI.java Show resolved Hide resolved
@tsaglam tsaglam merged commit 44a6a8d into develop Feb 19, 2024
9 checks passed
@tsaglam tsaglam deleted the feature/result-file-option branch February 19, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issue/PR that involves features, improvements and other changes minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants