Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match merging: Use default values for CLI #1563

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Conversation

uuqjz
Copy link
Contributor

@uuqjz uuqjz commented Feb 15, 2024

Fixed an issue where the default values where not used for the CLI.

@uuqjz uuqjz requested a review from tsaglam February 15, 2024 12:05
@tsaglam tsaglam added bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change labels Feb 15, 2024
@uuqjz uuqjz linked an issue Feb 15, 2024 that may be closed by this pull request
@uuqjz
Copy link
Contributor Author

uuqjz commented Feb 15, 2024

@tsaglam Ready for Review!

Copy link
Member

@tsaglam tsaglam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor things. Not all existing test cases fulfill this, but new ones should.

Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Plagiarism Detector'

Issues
0 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@uuqjz uuqjz requested a review from tsaglam February 15, 2024 15:48
@tsaglam tsaglam merged commit 0f2a6c9 into develop Feb 16, 2024
9 checks passed
@tsaglam tsaglam deleted the bug-fix/default-values-mm branch February 16, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue/PR that involves a bug minor Minor issue/feature/contribution/change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add test for default values for matchmerging with CLI and in Java
2 participants