Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code highlighting #1512

Merged
merged 3 commits into from
Feb 2, 2024
Merged

Fix code highlighting #1512

merged 3 commits into from
Feb 2, 2024

Conversation

Kr0nox
Copy link
Member

@Kr0nox Kr0nox commented Jan 29, 2024

The code highlighting for languages that are not nativly supported by highlight.js did not work. This is fixed now.
In addition highlighting for js/ts was not implemented in their pr. This is fixed now. To prevent this from happening again, there now is a small paragraph about it in the wiki

@Kr0nox Kr0nox requested review from tsaglam and sebinside January 29, 2024 18:48
@Kr0nox Kr0nox added the report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies label Jan 29, 2024
Copy link

Quality Gate Passed Quality Gate passed for 'JPlag Report Viewer'

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Kr0nox Kr0nox changed the title Report viewer/fix highlight Fix code highlighting Jan 30, 2024
@tsaglam tsaglam merged commit 3da1f57 into develop Feb 2, 2024
16 checks passed
@tsaglam tsaglam deleted the report-viewer/fix-highlight branch February 2, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
report-viewer PR / Issue deals (partly) with the report viewer and thus involves web-dev technologies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants